[foreign] RFR 8222739: Port CallingSequenceTest to Windows

[Henry Jen]

Looks reasonable to me.

Cheers,
Henry


> On Apr 23, 2019, at 4:10 AM, Jorn Vernee <jbvernee at xs4all.nl> wrote:
> 
> Hi,
> 
> I have ported the SysV CallingSequenceTest to Windows (and fixed a little bug in the process as well :) ).
> 
> In an effort to reduce code duplication in the tests, I have create a testing utility that automatically checks that the number of argument classes is correct. I've updated the existing SysV CallingSequenceTest to use this utility as well. You just have to specify the argument, and the expected bindings e.g. :
> 
>    new Verifier(new CallingSequenceBuilderImpl(null))
>            .arg(Layout.of("[u64u64u64u64]"),
>                    binding(STACK_ARGUMENT_SLOT, 0),
>                    binding(STACK_ARGUMENT_SLOT, 8),
>                    binding(STACK_ARGUMENT_SLOT, 16),
>                    binding(STACK_ARGUMENT_SLOT, 24))
>            .check(false);
> 
> Specifies 1 argument with the layout "[u64u64u64u64]", which is expected to have 4 bindings.
> 
> Please review the following.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222739
> Webrev: http://cr.openjdk.java.net/~jvernee/panama/webrevs/8222739/webrev.00/
> 
> Thanks,
> Jorn