[vector] Fix compiler errors
Viswanathan, Sandhya
sandhya.viswanathan at intel.com
Wed Dec 4 21:04:43 UTC 2019
Hi Paul,
Your changes look good to me. Jatin was planning to take a look at fixing MinShort64Test failure.
Best Regards,
Sandhya
-----Original Message-----
From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of Paul Sandoz
Sent: Wednesday, December 04, 2019 10:03 AM
To: panama-dev <panama-dev at openjdk.java.net>
Subject: [vector] Fix compiler errors
Fix some compiler errors (warnings as errors) for some logical expressions:
http://cr.openjdk.java.net/~psandoz/panama/vector-hs-errors/webrev/ <http://cr.openjdk.java.net/~psandoz/panama/vector-hs-errors/webrev/>
Separately when running all the tests I observed this single failure on by Mac book:
test Short64VectorTests.MINShort64VectorTests(short[i * 5]): failure
java.lang.IndexOutOfBoundsException: Index 1560 out of bounds for length 1557
at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
at java.base/java.util.Objects.checkIndex(Objects.java:373)
at jdk.incubator.vector/jdk.incubator.vector.VectorIntrinsics.checkFromIndexSize(VectorIntrinsics.java:496)
at jdk.incubator.vector/jdk.incubator.vector.ShortVector.fromArray(ShortVector.java:2799)
at Short64VectorTests.MINShort64VectorTests(Short64VectorTests.java:2171)
I have not yet looked more closely as to the cause, but it is a curious one since over tests pass, such as MAXShort64VectorTests(short[i * 5]).
Paul.
More information about the panama-dev
mailing list