[foreign] RFR 8218281: jextract native library related command line options should be revisited

Anthony Vanelverdinghe anthonyv.be at outlook.com
Mon Feb 4 15:55:43 UTC 2019


Hi Sundar



In JModWriter.java there is:

-            if (ctx.libraryPaths.isEmpty() && ctx.linkCheckPaths.isEmpty()) {

+            if (ctx.libraryPaths.isEmpty() && ctx.libraryPaths.isEmpty()) {

but now both conditions are the same, so the second can be removed.



In Main.java there is an unintended whitespace change:

-        ctx.setGenStaticForwarder(staticForwarder && options.has("l"));

+        ctx.setGenStaticForwarder(staticForwarder&& options.has("l"));



Kind regards

Anthony



________________________________
From: panama-dev <panama-dev-bounces at openjdk.java.net> on behalf of Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>
Sent: Monday, February 4, 2019 3:24:00 PM
To: 'panama-dev at openjdk.java.net'
Subject: [foreign] RFR 8218281: jextract native library related command line options should be revisited

Please review.

Bug: https://bugs.openjdk.java.net/browse/JDK-8218281
Webrev: https://cr.openjdk.java.net/~sundar/8218281/webrev.00/

Thanks,
-Sundar


More information about the panama-dev mailing list