[vector api] RFR: Fine-tune test cases for reduction operations

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Tue Feb 12 01:36:53 UTC 2019


Though I like the changes you propose, I don't see how they improve test 
coverage. It implies C2 does the following transformation, but I don't 
think that's the case (yet):

   AddI i (AddReductionVI (ConI 0) v) => AddReductionVI i v

Am I missing something?

Best regards,
Vladimir Ivanov

On 11/02/2019 00:25, Yang Zhang (Arm Technology China) wrote:
> Hi
> 
> Currently, test cases of reduction operations only check the intermediate result (the result of one vector), not final result ( the result of one array). So that for following examples, src1 is always initial value without this patch.
> instruct rsadd2I_reduction_reg(rRegI dst, rRegI src1, vecD src2, vecD tmp, vecD tmp2) %{  ----------------------X86
> instruct reduce_add2I(iRegINoSp dst, iRegIorL2I src1, vecD src2, iRegINoSp tmp, iRegINoSp tmp2) ------------------AArch64
> To cover more cases, I add test cases that check the final result of reduction operations. Some indentation errors are also fixed.
> With this patch, all Vector API tests are passed.
> 
> Could you please help to review this patch?
> http://cr.openjdk.java.net/~yzhang/vectorapi.test/webrev.00/
> 
> Regards,
> Yang
> 


More information about the panama-dev mailing list