[foreign] RFR 8219119: Need API to create a null Callback

[Jorn Vernee]

Hi Sundar,

You've changed the implementation of theNullCallback to throw an 
exception in an overridden asFunction(), but the boxing code in 
References.OfFunction and DirectSignatureShuffler (others?) would still 
have to be updated to return theNullCallback explicitly when the address 
is 0.

Jorn

Sundararajan Athijegannathan schreef op 2019-02-18 04:52:
> Updated: https://cr.openjdk.java.net/~sundar/8219119/webrev.01/
> 
> Thanks
> -Sundar
> 
> On 15/02/19, 10:33 PM, Maurizio Cimadamore wrote:
>> Looks good - but I think it can be simplified further - there's no 
>> need to accept a carrier type in Callback::ofNull.
>> 
>> You can just create a CallbackImpl which throws NPE whenever you try 
>> to call 'asFunction'.
>> 
>> Maurizio
>> 
>> On 15/02/2019 17:00, Sundararajan Athijegannathan wrote:
>>> Please review.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219119
>>> Webrev: https://cr.openjdk.java.net/~sundar/8219119/webrev.00/
>>> 
>>> Thanks,
>>> -Sundar