[vector] RFR (M): Ensure intrinsics are parameterized with non-capturing lambdas
John Rose
john.r.rose at oracle.com
Wed Feb 20 23:13:10 UTC 2019
Reviewed, with pleasure.
"Save months of performance debugging with this one weird trick!"
— John
On Feb 20, 2019, at 2:32 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>
> http://cr.openjdk.java.net/~vlivanov/panama/vector/intrin.non_capturing/webrev.00/
>
> Default implementations are implemented as lambdas and capturing introduces problems for EA and even if intrinsification happens may leave unused objects behind.
>
> The patch:
>
> * introduces an adhoc check (VectorIntrinsics.isNonCapturingLambda()) and asserts all default implementations satisfy it;
>
> * instruments existing tests to run with assertions enabled;
>
> * fixes all occurrences of capturing lambdas in the code (so test results are clean).
>
> Best regards,
> Vladimir Ivanov
More information about the panama-dev
mailing list