[vector] RFR : Removed subAll() and few javadoc changes

Kharbas, Kishor kishor.kharbas at intel.com
Mon Feb 25 19:31:49 UTC 2019


Hi Yang,

> -----Original Message-----
> From: Yang Zhang (Arm Technology China) [mailto:Yang.Zhang at arm.com]
> Sent: Monday, February 25, 2019 12:44 AM
> To: Kharbas, Kishor <kishor.kharbas at intel.com>; panama-
> dev at openjdk.java.net
> Subject: RE: [vector] RFR : Removed subAll() and few javadoc changes
> 
> Hi Kishor
> 
> Currently I'm implementing subAll() for AArch64.
> Could you please help to explain:
> 1. What's the motivation of removing subAll() ?

As part of API review, we found that subAll() does not have a clear semantic meaning. So it was decided to remove it.

> 2. If subAll() should be removed,  why not remove the middle-end and the
> x86 backend about subAll() ?

Yes, the implementation of it should be removed too. I focused on api changes so did not remove the other parts.

Regards,
Kishor
> 
> Regards,
> Yang
> 
> -----Original Message-----
> From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of
> Kharbas, Kishor
> Sent: Saturday, February 23, 2019 10:37 AM
> To: panama-dev at openjdk.java.net
> Subject: [vector] RFR : Removed subAll() and few javadoc changes
> 
> Hi,
> 
> Requesting review for a patch to,
> 
> 1.       Remove subAll() method from vectors.
> 
> 2.       Javadoc - add missing parameter definitions.
> 
> 3.       Changed javadoc specification of reduction operations on floating point
> vectors.
> 
> Link : http://cr.openjdk.java.net/~kkharbas/vector-
> api/webrev_suball_javadoc.00/
> 
> Thank you,
> Kishor
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.


More information about the panama-dev mailing list