[foreign] RFR 8216483: jextract tests have to be modified to run on Windows platform

[Jorn Vernee]

I put copyright headers into the files that I created.

There are also some other files missing copyright headers I noticed. 
Should I add them as well, if so, what year should I put in the header?

Thanks,
Jorn

Sundararajan Athijegannathan schreef op 2019-01-11 07:16:
> Looks good.
> 
> Tests run fine on Linux as well. If all fine on Windows, please push.
> 
> PS. New test source files should have copyright year 2019
> 
> -Sundar
> 
> On 11/01/19, 7:51 AM, Sundararajan Athijegannathan wrote:
>> All test run fine on Mac with this latest patch! I'll test on Linux as 
>> well and then send you review comments.
>> 
>> -Sundar
>> 
>> On 10/01/19, 9:40 PM, Jorn Vernee wrote:
>>> Hi,
>>> 
>>> Continuation of [1].
>>> 
>>> updated webrev: 
>>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/windows_tests/webrev.04/
>>> 
>>> For the TestJextractFFI test I'm now just checking the operating 
>>> system in the LibClang.java patch file:
>>> 
>>>     String libName = 
>>> System.getProperty("os.name").startsWith("Windows")
>>>             ? "libclang"
>>>             : "clang";
>>>     Library libclang = Libraries.loadLibrary(MethodHandles.lookup(), 
>>> libName);
>>> 
>>> The other problem is that the dll is in the bin folder vs lib folder 
>>> on Windows, and the test was using the linker path which is the lib 
>>> folder on Windows. There was no build system variable available for 
>>> the folder that contains the library file, so instead I'm deriving it 
>>> from the library file path.
>>> 
>>> Cheers,
>>> Jorn
>>> 
>>> [1] : 
>>> https://mail.openjdk.java.net/pipermail/panama-dev/2019-January/003691.html