[foreign] RFR 8217164: Enable jextract to handle function types in parameters

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Jan 17 10:18:10 UTC 2019


Looks good.

-Sundar

On 17/01/19, 1:49 PM, Jorn Vernee wrote:
> Thanks, I added the check.
>
> Updated webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8217164/webrev.01/
>
> Jorn
>
> Sundararajan Athijegannathan schreef op 2019-01-17 07:48:
>> Looks good. Built & tested on Mac.
>>
>> Minor: test assumes testCB(int i) is reached and asserts the value.
>> What if the test method was not reached? Perhaps reached boolean flag
>> that is set inside the method testCB and assertion on field from the
>> caller?
>>
>> -Sundar
>>
>> On 17/01/19, 3:31 AM, Jorn Vernee wrote:
>>> Hi,
>>>
>>> Please review the following patch which allows jextract to handle 
>>> function signatures with simple function types as parameter types e.g.:
>>>
>>>     void func(void callback(int)) { // function taking a pointer to 
>>> function taking an int
>>>         // ...
>>>     }
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217164
>>> Webrev: 
>>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8217164/webrev.00/
>>>
>>> Thanks,
>>> Jorn


More information about the panama-dev mailing list