[foreign] Instructions for using libraries on Windows

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Jan 17 20:50:54 UTC 2019


Looks good,

before pushing, please revert changes to building.html and testing.html

Cheers
Maurizio

On 17/01/2019 18:57, Jorn Vernee wrote:
> Ok, the format didn't seem super consistent so I just went with what 
> seemed convenient. I've tried to follow the section format that was 
> already present for each library now.
>
> Updated webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/instructions/webrev.02/
>
> Jorn
>
> Maurizio Cimadamore schreef op 2019-01-17 19:37:
>> Another note, we have separate sections for different platforms - I
>> see that your changes create a single section for OpenGL for both
>> Windows and Linux - would be better to tease them apart, and then just
>> say that the example on Windows is the same (as done for other
>> examples).
>>
>> Also, please separate installation from extraction, as it happens for
>> the other sections.
>>
>> Cheers
>>
>> Maurizio
>>
>>
>> On 17/01/2019 18:30, Jorn Vernee wrote:
>>> Good catch.
>>>
>>> Here is the updated webrev: 
>>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/instructions/webrev.01/
>>>
>>> I've also added specific command lines for building/running on 
>>> Windows (I was using intellij before).
>>>
>>> Jorn
>>>
>>> Maurizio Cimadamore schreef op 2019-01-17 19:14:
>>>> The changes you made look good - only nit, in the Windows notes you
>>>> mention "Visual Studios" (note the plural) a few times - I'd replace
>>>> with the singular form.
>>>>
>>>> The rest is good
>>>>
>>>> Maurizio
>>>>
>>>> On 17/01/2019 17:27, Jorn Vernee wrote:
>>>>> I got the .html generation working with the help of Erik from 
>>>>> build-dev, so I think I can manage myself.
>>>>>
>>>>> Want me to sent an RFR with an actual webrev as well?
>>>>>
>>>>> Jorn
>>>>>
>>>>> Maurizio Cimadamore schreef op 2019-01-17 18:20:
>>>>>> Let us know if you need help with pushing this
>>>>>>
>>>>>> Thanks for trying this out on Windows!
>>>>>>
>>>>>> Maurizio
>>>>>>
>>>>>> On 17/01/2019 16:48, Jorn Vernee wrote:
>>>>>>>> The `make update-build-doc` does not work on windows [1], so I ask
>>>>>>>> that you generate the .html dos for me instead.
>>>>>>>
>>>>>>> Apologies. It seems to be a configuration problem on my end, and 
>>>>>>> not necessarily a problem with Windows.
>>>>>>>
>>>>>>> Jorn
>>>>>>>
>>>>>>> Jorn Vernee schreef op 2019-01-17 17:36:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I have updated panama_foreign.md with instructions for 
>>>>>>>> jextracting and
>>>>>>>> running OpenGL and Python. I have also tried other Windows 
>>>>>>>> applicable
>>>>>>>> libraries, here were the issues:
>>>>>>>>
>>>>>>>> LAPACK & BLAS: require libgfortran-3 as a dependency, which I 
>>>>>>>> couldn't
>>>>>>>> find a binary distro for so quickly. (MINGW has a package for 
>>>>>>>> it, but
>>>>>>>> only libgfortran-4)
>>>>>>>>
>>>>>>>> Tensorflow: is crashing jextract with a stack overflow error.
>>>>>>>>
>>>>>>>> ```
>>>>>>>>     Exception in thread "main" java.lang.StackOverflowError
>>>>>>>>         at
>>>>>>>> jdk.internal.clang/jdk.internal.clang.StructType.<init>(StructType.java:37) 
>>>>>>>>         at
>>>>>>>> jdk.internal.clang/jdk.internal.clang.StructType.<init>(StructType.java:32) 
>>>>>>>>         at 
>>>>>>>> jdk.internal.clang/jdk.internal.clang.Type.<init>(Type.java:30)
>>>>>>>>         at
>>>>>>>> jdk.internal.clang/jdk.internal.clang.Type.canonicalType(Native
>>>>>>>> Method)
>>>>>>>>         at
>>>>>>>> jdk.jextract/com.sun.tools.jextract.TypeDictionary.getInternal(TypeDictionary.java:134) 
>>>>>>>>         at
>>>>>>>> jdk.jextract/com.sun.tools.jextract.TypeDictionary.getInternal(TypeDictionary.java:134) 
>>>>>>>>         at
>>>>>>>> jdk.jextract/com.sun.tools.jextract.TypeDictionary.getInternal(TypeDictionary.java:134) 
>>>>>>>>         at
>>>>>>>> jdk.jextract/com.sun.tools.jextract.TypeDictionary.getInternal(TypeDictionary.java:134) 
>>>>>>>>         ...
>>>>>>>> ```
>>>>>>>>
>>>>>>>> FWIW, you made a note about needing to pass `-C -c -C c++` to 
>>>>>>>> jextract
>>>>>>>> so it doesn't interpret some methods as varargs. I've tried 
>>>>>>>> without
>>>>>>>> those flags and am observing the same vararg problem, but in 
>>>>>>>> that case
>>>>>>>> extraction does succeed.
>>>>>>>>
>>>>>>>> The other libraries libproc, readline, and unistd don't seem
>>>>>>>> applicable to Windows. I will be on the lookout for Windows 
>>>>>>>> specific
>>>>>>>> examples that could be interesting.
>>>>>>>>
>>>>>>>> The `make update-build-doc` does not work on windows [1], so I ask
>>>>>>>> that you generate the .html dos for me instead.
>>>>>>>>
>>>>>>>> Here is the updated panama_foreign.md:
>>>>>>>> http://cr.openjdk.java.net/~jvernee/panama/panama_foreign.md
>>>>>>>>
>>>>>>>> Jorn
>>>>>>>>
>>>>>>>> [1] : 
>>>>>>>> https://mail.openjdk.java.net/pipermail/build-dev/2019-January/024666.html


More information about the panama-dev mailing list