[foreign] RFR 8217380: LayoutType::ofStruct should try to resolve Struct layout

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Mon Jan 21 12:53:32 UTC 2019


On 21/01/2019 10:52, Maurizio Cimadamore wrote:
> Hi,
> I've been wanting to solve this in the past, but I stumbled upon the 
> fact that we could not always ensure 'eager' resolution when calling 
> LayoutType.ofStruct. This is something that eventually should be fixed 
> - the situations where such resolution cannot happen are always caused 
> by the fact that jextract is generating cross-header symbolic 
> references - this is another problem that could be addressed by 
> switching to a library-per-extraction approach, where then all 
> symbolic references will become self-contained.
>
> In the meantime, your idea of adding a 'tryResolve' is a good one; 
> I'll do some more tests on my side, to make sure that everything is 
> ok, and then I'll approve

All tests look good - this can go ahead

Maurizio

>
> Cheers
> Maurizio
>
> On 19/01/2019 15:16, Jorn Vernee wrote:
>> Hi,
>>
>> Please review the following patch.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217380
>> Webrev: 
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8217380/webrev.00/
>>
>> Thanks,
>> Jorn


More information about the panama-dev mailing list