[foreign] RFR 8217453: add support for member annotation scheme

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Tue Jan 22 05:34:36 UTC 2019



* test/jdk/com/sun/tools/jextract/staticForwarder/StaticForwarderTest.java

Unused import for NativeSetter?

* NativeGetter and NativeSetter annotations allow target to be 
ElementType.TYPE as well.  We need only METHOD, right? or am I missing 
something?

* test/jdk/java/foreign/OutOfBoundsTest.java (latest test added) still 
uses older 'declarations' field in NativeHeader annotation.

PS. I can jextract and run lapack example on Mac (this sample used to 
fail in jextract step).

-Sundar

On 21/01/19, 11:00 PM, Maurizio Cimadamore wrote:
> Forgot to mention: the patch passes tests on all platforms.
>
> Maurizio
>
> On 21/01/2019 16:52, Maurizio Cimadamore wrote:
>> Hi,
>> this patch implements the member-based annotation scheme described here:
>>
>> http://cr.openjdk.java.net/~mcimadamore/panama/panama-annos.html
>>
>> (see end of document)
>>
>> This patch diverges from the proposal in two minor aspects:
>>
>> * @NativeCallback is left in place (we have bigger plans for allowing 
>> callback types to be referenced by name)
>> * unresolved layout grammar: the layout expression used braces - e.g. 
>> ${foo}, not $(foo), to minimize confusion with layout annotations
>>
>> I've also took care of a couple of minor issues:
>>
>> * I added exclusion for the SystemHeadersTest which fails on Windows 
>> if Visual Studio is not installed
>> * I fixed a bunch of javadoc issues (esp. in Pointer) which prevented 
>> javadoc to be generated correctly
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~mcimadamore/panama/8217453/
>>
>> Thanks
>> Maurizio
>>


More information about the panama-dev mailing list