[foreign] RFR: Update (Windows) build docs

[Jorn Vernee]

Thanks for the review! Pushed.

Jorn

Maurizio Cimadamore schreef op 2019-01-23 13:11:
> Good thanks!
> 
> Maurizio
> 
> On 23/01/2019 11:55, Jorn Vernee wrote:
>> Good catch. I missed this when reviewing the webrev locally. It must 
>> have been added when copy-pasting the markdown from the online editor 
>> I was using to the local .md file.
>> 
>> Updated webrev: 
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/updateddocs/webrev.01/
>> 
>> Jorn
>> 
>> Maurizio Cimadamore schreef op 2019-01-23 12:47:
>>> Looks good.
>>> 
>>> The only weird bit is that there seems to be a spurious line (after
>>> the table of contents):
>>> 
>>> "% Using Panama "foreign" JDK"
>>> 
>>> here:
>>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/updateddocs/webrev.00/raw_files/new/doc/panama_foreign.html 
>>> Which is missing in the current version:
>>> http://hg.openjdk.java.net/panama/dev/raw-file/foreign/doc/panama_foreign.html 
>>> In fact, if you look at the HTML diff, you will find this extra 
>>> paragraph:
>>> 
>>> +<p>% Using Panama "foreign" JDK</p>
>>> 
>>> It seems like you have added  some extra newline on top of the "%"
>>> directive in the md file - maybe that's the culprit. Or maybe it's
>>> just to do with the pandoc version being used?
>>> 
>>> Maurizio
>>> 
>>> On 23/01/2019 11:33, Jorn Vernee wrote:
>>>> Hi,
>>>> 
>>>> I've taken a second pass over the build documentation. I have now:
>>>> 
>>>> - Added Windows instructions for Tensorflow.
>>>> - Simplified some of the Windows commands by taking advantage of 
>>>> --infer-rpath
>>>> - Updated the OpenGL example to take advantage of static forwarders.
>>>> - Miscellaneous fixes & simplifications here and there.
>>>> 
>>>> Please review the changes.
>>>> 
>>>> Webrev: 
>>>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/updateddocs/webrev.00/
>>>> 
>>>> Thanks,
>>>> Jorn