[foreign] RFR 8217727: drop AVX compiler directives from panama/foreign tests
Sundararajan Athijegannathan
sundararajan.athijegannathan at oracle.com
Thu Jan 24 14:37:55 UTC 2019
Looks good
-Sundar
On 24/01/19, 7:03 PM, Maurizio Cimadamore wrote:
> Well spotted - I ran tests on all platforms, but probably depends on
> how the shell is setup.
>
> Another attempt:
>
> http://cr.openjdk.java.net/~mcimadamore/panama/8217727_v2/
>
> Maurizio
>
> On 24/01/2019 13:24, Jorn Vernee wrote:
>> Hi Maurizio,
>>
>> This patch is throwing an error for me when running the tests:
>>
>> /bin/find: ‘else’: No such file or directory
>>
>> It seems that there is a spurious `\` in /make/test/JtregNativeJdk.gmk:
>>
>> diff -r 3b9dc4b788e2 make/test/JtregNativeJdk.gmk
>> --- a/make/test/JtregNativeJdk.gmk Thu Jan 24 14:10:29 2019 +0100
>> +++ b/make/test/JtregNativeJdk.gmk Thu Jan 24 14:24:10 2019 +0100
>> @@ -47,7 +47,7 @@
>> # Only build java.foreign tests on x64 for now
>> ifneq ($(filter x86_64, $(OPENJDK_TARGET_CPU)),)
>> BUILD_JDK_JTREG_NATIVE_SRC += \
>> - $(TOPDIR)/test/jdk/java/foreign \
>> + $(TOPDIR)/test/jdk/java/foreign
>> else
>> $(info Not building java.foreign tests)
>> endif
>>
>>
>> Otherwise this looks good.
>>
>> Cheers,
>> Jorn
>>
>> Maurizio Cimadamore schreef op 2019-01-24 14:07:
>>> Hi,
>>> the use of some AVX specific settings in some Panama/foreign tests can
>>> cause spurious failures when tests are executed on platforms w/o AVX
>>> support.
>>>
>>> This patch removes AVX-specific dependencies from tests.
>>>
>>> http://cr.openjdk.java.net/~mcimadamore/panama/8217727/
>>>
>>> Cheers
>>> Maurizio
More information about the panama-dev
mailing list