[vector api] RFR: Implement Vector API andAll/orAll/xorAll for AArch64 NEON

[Yang Zhang (Arm Technology China)]

Hi Andrew

Thanks very much for your suggestion. aarch64_ad.m4 will make the code easy to maintain and review. I have updated the patch. Could you please help to review it again?
http://cr.openjdk.java.net/~yzhang/vectorapi.andall/webrev.01/

Regards
Yang

-----Original Message-----
From: Andrew Haley <aph at redhat.com> 
Sent: Monday, January 28, 2019 6:13 PM
To: Yang Zhang (Arm Technology China) <Yang.Zhang at arm.com>; 'panama-dev at openjdk.java.net' <panama-dev at openjdk.java.net>
Subject: Re: [vector api] RFR: Implement Vector API andAll/orAll/xorAll for AArch64 NEON

On 1/28/19 2:44 AM, Yang Zhang (Arm Technology China) wrote:
> I have a patch which implements Vector API andAll/orAll/xorAll for AArch64 NEON. Could you please help to review it?
> http://cr.openjdk.java.net/~yzhang/vectorapi.andall/webrev.00/

OK, but:

You're doing a great deal of repetitive stuff in here. This makes the patch hard to maintain and review. Instead, I suggest that you have a look at aarch64_ad.m4 to see how it's possible to generate all of these patterns from a script: 487 lines of that script generates 1970 lines of patterns.

--
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671