[foreign] RFR: 8227125: java/foreign/pthread/Threads.java asserts on debug build

[Maurizio Cimadamore]

You are right, I checked the code and I was kind of expecting the assert 
to be earlier up, for some reason.

Code looks very good, thanks for catching this.

Maurizio

On 03/07/2019 10:22, Nick Gasson wrote:
> Hi Maurizio,
>
>> Looks great - one question - in the universal invokers there's no assert
>> for whether the thread you get back is indeed a Java thread, whereas the
>> assert is there in the upcall handlers. Why?
>>
>
> Do you mean the universal vs direct upcall handler? The existing code 
> in universalUpcallHandler_* already had an assert on is_Java_thread() 
> a bit later (but JavaThread::current() would have already checked 
> this). So I just added it to the direct upcall handler which had no 
> assert before.
>
> Forgot to mention I tested this with jtreg jdk_foreign on x86 and 
> AArch64 (fastdebug).
>
>
> Thanks,
> Nick