[foreign-memacces] RFR 8227278: Remove CompoundLayout

Jorn Vernee jbvernee at xs4all.nl
Mon Jul 8 10:45:56 UTC 2019


Hi,

Really like this patch!

Some comments:

- Part of the CoumpoundLayout.Path javadoc was moved to Layout it seems, 
but the text still mentions 'compound layout' here and there.
- Layout::dereferenceHandle javadoc mentions a `pathOperator`, but this 
doesn't seem to exist for this method (guess it was changed to 
`elements`?)

Jorn

On 2019-07-04 17:48, Maurizio Cimadamore wrote:
> Hi,
> this is an official RFR for the work described here:
> 
> https://mail.openjdk.java.net/pipermail/panama-dev/2019-July/005906.html
> 
> I've made few changes to the patches shared there - more specifically:
> 
> * I removed the Layout::elements method
> * I removed GroupLayout::elementAt and GroupLayout::elementsSize, and
> iterable interface - and replaced them with
> GroupLayout::memberLayouts() -> List<Layout> - after all, once you
> have the list of member layouts you can obtain all the other info as
> well
> * I tightened the wording: a group layout has _member_ layouts; a
> sequence layout has an _element_ layout.
> 
> The rest should be the same as yesterday.
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~mcimadamore/panama/8227278/
> 
> javadoc:
> 
> http://cr.openjdk.java.net/~mcimadamore/panama/8227278_javadoc
> 
> Cheers
> Maurizio


More information about the panama-dev mailing list