[foreign-abi] RFR: 8228762: import CallingSequenceBuilder unit tests

Jorn Vernee jbvernee at xs4all.nl
Tue Jul 30 10:59:10 UTC 2019


Looks good to me!

Thanks,
Jorn

On 2019-07-30 11:24, Nick Gasson wrote:
> Hi,
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8228762
> Webrev: http://cr.openjdk.java.net/~ngasson/foreign/8228762/
> 
> This patch modifies the three CallingSequenceTest unit tests from the
> foreign branch to work with the MemoryLayout API in foreign-abi. Also
> changed the AArch64 test to use CallingSequenceTestBase to match
> Windows/SysV.
> 
> I also modified MemoryLayouts so the AArch64 C_* constants are all
> little rather than big endian. Although the ABI officially supports
> both big and little endian, big endian is almost never used in
> practice, and in Hotspot we only support little endian AArch64.
> 
> Thanks,
> Nick


More information about the panama-dev mailing list