[foreign-abi] RFR: 8228762: import CallingSequenceBuilder unit tests
Jorn Vernee
jbvernee at xs4all.nl
Wed Jul 31 10:23:46 UTC 2019
I'm okay with dropping it. ArgumentClassTest actually pre-dates me being
a part of the project :) (I added CallingSequenceTestBase not too long
ago in this area though, when I added the Windows version of
CallingSequenceTest)
Jorn
On 2019-07-31 10:10, Nick Gasson wrote:
> Hi Maurizio,
>
>> Looks good, but I'm a bit puzzled by the ArgumentClassTest; in general
>> the test seems pretty obscure - but there's also the problem that the
>> test is ultimately SysV specific, so it will only stress the
>> ArgumentClassImpl specific to SysV. Not sure this test is robust
>> enough
>> (as the other) to make the cut, to be honest.
>>
>> What do you think?
>>
>
> This one got included because I took the whole test/jdk/foreign/abi
> directory from the foreign branch. I agree it's not as useful as the
> main CallingSequenceTest which should test the merge method indirectly
> anyway. I'm happy to take it out of this patch if Jorn agrees too? (I
> think he added it originally.)
>
>
> Nick
More information about the panama-dev
mailing list