[foreign] RFR 8225717: jclang-ffi test misses macro evaluation

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Jun 13 16:17:08 UTC 2019


Thanks for the review. Tried to keep it in (approx.) sync with 
jdk.internal.clang built-in module for easier porting.

-Sundar

On 13/06/19, 8:41 PM, Henry Jen wrote:
> Looks good to me, personally I’ll get rid of those private xx0() methods and simply put in place at call sites.
>
> Cheers,
> Henry
>
>
>> On Jun 13, 2019, at 7:46 AM, Sundararajan Athijegannathan<sundararajan.athijegannathan at oracle.com>  wrote:
>>
>> Please review.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225717
>> Webrev: https://cr.openjdk.java.net/~sundar/8225717/webrev.00/
>>
>> Thanks,
>> -Sundar


More information about the panama-dev mailing list