[foreign-memaccess] RFR 8225720: Cleanup var handle address generation with byte carriers
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Thu Jun 13 20:50:44 UTC 2019
On 13/06/2019 19:19, Jorn Vernee wrote:
> Looks like a link to an old webrev. I'm guessing this is the right
> link: http://cr.openjdk.java.net/~mcimadamore/panama/8225720_v2 ?
>
> That one looks good.
Whoops again - yes, thanks!
Maurizio
>
> Cheers,
> Jorn
>
> On 2019-06-13 20:07, Maurizio Cimadamore wrote:
>> On 13/06/2019 18:02, Jorn Vernee wrote:
>>> Looks good!
>>>
>>> FWIW, I noticed some #if[Object] blocks in compareAndSet0 and
>>> getAndSet0. Are these being used? (since we can not have object
>>> carriers)
>>
>> Whoops - no, they are not used...
>>
>> Cleaned those up too:
>>
>> http://cr.openjdk.java.net/~mcimadamore/panama/8224993_followup_v2/
>>
>> Maurizio
>>
>>
>>>
>>> Cheers,
>>> Jorn
>>>
>>> On 2019-06-13 17:35, Maurizio Cimadamore wrote:
>>>> Hi,
>>>> the template for var handle memaccess generation has some leftovers
>>>> from when we did bit swapping on 'byte' carriers. We have removed that
>>>> in [1], so we can now clean up the code for good.
>>>>
>>>> Webrev:
>>>>
>>>> http://cr.openjdk.java.net/~mcimadamore/panama/8225720/
>>>>
>>>> Maurizio
>>>>
>>>> [1] -
>>>> https://mail.openjdk.java.net/pipermail/panama-dev/2019-May/005597.html
>>>>
More information about the panama-dev
mailing list