[foreign] RFR: 8225686: Pointer access struct field failed with SecurityManager

[Henry Jen]

Of course! Thank you. :)

Cheers,
Henry

> On Jun 17, 2019, at 8:23 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> There is sun.security.action.GetPropertyAction for string valued properties.
> 
> -Sundar
> 
> On 17/06/19, 8:50 PM, Henry Jen wrote:
>> That is for boolean property, I am getting two String properties. I was looking around, but not finding it.
>> 
>> Cheers,
>> Henry
>> 
>>> On Jun 17, 2019, at 1:53 AM, Sundararajan Athijegannathan<sundararajan.athijegannathan at oracle.com>  wrote:
>>> 
>>> Haven't looked at everything. Quick comment in NativeTypes.java. That doPrivileged block is not needed. sun.security.action.GetBooleanAction.privilegedGetProperty can be used - that is the standard way of reading system properties from code in java.base module.
>>> 
>>> -Sundar
>>> 
>>> On 14/06/19, 12:45 AM, Henry Jen wrote:
>>>> Hi,
>>>> 
>>>> Please review webrev[1] for JDK-8225686[2].
>>>> 
>>>> The fix is to ensure pointer access works under SecurityManager, the test case should work with java.foreign.Scope permission granted, but there are two area where SecurityException could be thrown.
>>>> 
>>>> Also in the webrev, there is a cleanup for libeling binding to remove disposed TU from the ClangUtils.
>>>> 
>>>> Cheers,
>>>> Henry
>>>> 
>>>> [1] http://cr.openjdk.java.net/~henryjen/panama/8225686/0/webrev/
>>>> [2] https://bugs.openjdk.java.net/browse/JDK-8225686