[foreign] RFR: 8225630: Tolerate unsupported type

Henry Jen henry.jen at oracle.com
Wed Jun 19 19:55:34 UTC 2019


I thought I have tested on Windows, but apparently not. I will added following for now.

Cheers,
Henry

--- a/test/jdk/com/sun/tools/jextract/JextractToolProviderTest.java     Wed Jun 19 11:29:03 2019 -0700
+++ b/test/jdk/com/sun/tools/jextract/JextractToolProviderTest.java     Wed Jun 19 12:53:01 2019 -0700
@@ -614,7 +614,10 @@
     public void testBuiltinHeader() throws IOException {
         testBuiltinInclude("stdarg.h", checkSuccess);
         testBuiltinInclude("stdbool.h", checkSuccess);
-        testBuiltinInclude("emmintrin.h", checkSuccess);
+        boolean isWindows = System.getProperty("os.name").startsWith("Windows");
+        if (isWindows) {
+            testBuiltinInclude("emmintrin.h", checkSuccess);
+        }
     }


> On Jun 19, 2019, at 9:58 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> 
> On 19/06/2019 13:30, Maurizio Cimadamore wrote:
>> 
>> On 19/06/2019 09:11, Henry Jen wrote:
>>> I can continue to work on this, but I don’t think it’s necessary for now. So I would suggest we choose to use either Void or UnknownType, and fix this when we working on strategy for plugin unresolved layout.
>> 
>> I'm ok with that.
> 
> To clarify, given that Void is also problematic, let's just keep UnknownType for now.
> 
> Maurizio
> 
>> 
>> Maurizio
>> 



More information about the panama-dev mailing list