[foreign] RFR: 8225630: Tolerate unsupported type

Henry Jen henry.jen at oracle.com
Thu Jun 20 07:43:40 UTC 2019


Thanks for pointing this out, I’ll fix it.

Cheers,
Henry


> On Jun 19, 2019, at 7:24 PM, Nick Gasson <nick.gasson at arm.com> wrote:
> 
>> Sorry, should be !isWindows.
>> 
>> Cheers,
>> Henry
>> 
>>> On Jun 19, 2019, at 12:55 PM, Henry Jen <henry.jen at oracle.com> wrote:
>>> 
>>> I thought I have tested on Windows, but apparently not. I will added following for now.
>>> 
> 
> Hi Henry,
> 
> This header is only for X86 so you need to check the architecture
> too. Something like:
> 
> --- a/test/jdk/com/sun/tools/jextract/JextractToolProviderTest.java
> +++ b/test/jdk/com/sun/tools/jextract/JextractToolProviderTest.java
> @@ -614,7 +614,13 @@ public class JextractToolProviderTest extends JextractToolRunner {
>     public void testBuiltinHeader() throws IOException {
>         testBuiltinInclude("stdarg.h", checkSuccess);
>         testBuiltinInclude("stdbool.h", checkSuccess);
> -        testBuiltinInclude("emmintrin.h", checkSuccess);
> +
> +        boolean isX86 = System.getProperty("os.arch").equals("x86_64")
> +            || System.getProperty("os.arch").equals("amd64");
> +        boolean isWindows = System.getProperty("os.name").startsWith("Windows");
> +        if (isX86 && !isWindows) {
> +            testBuiltinInclude("emmintrin.h", checkSuccess);
> +        }
>     }
> 
> 
> Thanks,
> Nick



More information about the panama-dev mailing list