[foreign] RFR: 8226457: Refactor duplicated code in universalNativeInvoker
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Thu Jun 20 14:15:47 UTC 2019
Tests look good (aside from the windows failure on
JextractToolProviderTest, which Henry is taking care of, and has nothing
to do with this patch).
Looks good to go!
Thanks
Maurizio
On 20/06/2019 11:03, Maurizio Cimadamore wrote:
> Looks really good. I'll give it a spin on our test machines, just to
> double check. Stay tuned.
>
> Thanks
> Maurizio
>
> On 20/06/2019 07:02, Nick Gasson wrote:
>> Hi,
>>
>> This is an attempt to remove some of the duplication we now have
>> between the AArch64 and x86 versions of universalNativeInvoker. The
>> classes ShuffleRecipe, ShuffleRecipeStream and ShuffleRecipeVerifier
>> that were previously in universalNativeInvoker_{x86,aarch64}.cpp
>> actually have no platform-specific code so can go in the shared
>> universalNativeInvoker.[ch]pp.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8226457
>> Webrev: http://cr.openjdk.java.net/~ngasson/foreign/8226457/webrev.0/
>>
>> Tested jtreg jdk_foreign on X86 and AArch64.
>>
>> Thanks,
>> Nick
More information about the panama-dev
mailing list