[foreign-memaccess] RFR 8226421: Remove LayoutPath API
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Thu Jun 27 13:21:18 UTC 2019
Since there were no changes in the impl, I've decided to push this. We
can fix comments on later rounds anyway.
Maurizio
On 26/06/2019 18:34, Maurizio Cimadamore wrote:
> Here's the new patch:
>
> http://cr.openjdk.java.net/~mcimadamore/panama/8226421_v3/
>
> I've significantly cleaned up the javadoc around the layout
> path-related methods and classes and also added a test which is mostly
> inspired from the test that I had already put together for the
> original 'path language' patch.
>
> Maurizio
>
> On 26/06/2019 12:00, Maurizio Cimadamore wrote:
>> Thanks,
>>
>> I'll polish this and submit another webrev - I guess we could always
>> go down the string-y path at a later stage if we need to.
>>
>> Maurizio
>>
>> On 26/06/2019 11:03, Jorn Vernee wrote:
>>> I like this approach. I think the move to CompoundLayout.Path nicely
>>> shows where paths are useful. Compared to the string-y approach, I
>>> think it's a bit more robust.
>>>
>>> About the patch:
>>>
>>> In LayoutPathImpl.java
>>> - copyright was removed. I don't think that was intentional?
>>> - the 'enclosing' field is unused, so I guess that can be removed.
>>> - in sequenceElement(long), I think the check should be `index >=
>>> seq.elementsSize().getAsLong()`, i.e. using greater than.
>>>
>>> Rest looks good.
More information about the panama-dev
mailing list