[foreign] RFR: 8220006: jextract is expected to output descriptor with explicit endianness
Henry Jen
henry.jen at oracle.com
Sat Mar 2 07:08:59 UTC 2019
Follow up on the jextract fix to output the explicit endianness, please review this webrev[1]. Summary of the changes,
- Added a Address.withPointee(Descriptor), so that we can change the type of pointee,
- A few helper methods to “localize” the descriptor in Runner.java.
Although this is not as comprehensive as gold master file, it’s effective as we have both approaches and they have to match, that helps identify issues either way.
However, if we don’t mind to add templates for different endianness, we can go ahead and do that.
Alternatively, perhaps we can add extra annotation in template classes to express different expected descriptor and read the right one from Runner. That would be good for keeping all form of descriptors in place and maybe easier to maintain.
Thoughts?
Cheers,
Henry
[1] http://cr.openjdk.java.net/~henryjen/panama/8220006/0/webrev/
More information about the panama-dev
mailing list