[foreign] SrcGenTest fails on Windows.
Sundararajan Athijegannathan
sundararajan.athijegannathan at oracle.com
Thu Mar 21 01:39:21 UTC 2019
+1
Thanks for fixing this!
-Sundar
On 21/03/19, 5:01 AM, Maurizio Cimadamore wrote:
> Your fix looks good. Of course we never had this issue because
> classfiles are not touched by Java rules :-)
>
> And yes, an helper method to do the escaping would probably be a good
> idea.
>
> Maurizio
>
> On 20/03/2019 22:07, Jorn Vernee wrote:
>> Hi,
>>
>> After updating my local copy with the new source generation changes,
>> I'm running into a failure of SrcGenTest. The test sources that are
>> generated contain paths with backslashes that are not escaped, which
>> is causing the compilation of the generated sources to fail. I have
>> created the a JBS ticket for this:
>> https://bugs.openjdk.java.net/browse/JDK-8221178
>>
>> The following quickfix is making the test pass:
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/escapepaths/webrev.00
>>
>> But, maybe we need something for escaping the contents of string
>> literals in general?
>>
>> Jorn
More information about the panama-dev
mailing list