[foreign] RFR 8221177: Jextract should levarage file system specific path constraints when matching header paths

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Mar 21 01:42:43 UTC 2019


+1

If you want fullname, shouldn't it be asPathMatchPredicates?

PS. Noticed that weird newlines in webrev in one of the files I modified 
(in another patch) as well. But it shows fine in the source - no extra 
newline there..

-Sundar

On 21/03/19, 5:25 AM, Maurizio Cimadamore wrote:
> Looks good - couple of nits:
>
> * I find 'asPathmatchPredicates' a bit of a mouthful :-), maybe drop 
> the 'match' ?
>
> * there seem to be weird newlines both in Filters.java and 
> PatternFilter.java  - probably Windows-related?
>
> Maurizio
>
> On 20/03/2019 22:09, Jorn Vernee wrote:
>> Hi,
>>
>> This is an RFR for earlier discussed changes for file system specific 
>> path matching: 
>> https://mail.openjdk.java.net/pipermail/panama-dev/2019-March/004975.html
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221177
>> Webrev: 
>> http://cr.openjdk.java.net/~jvernee/panama/webrevs/caps/webrev.00/
>>
>> Thanks,
>> Jorn


More information about the panama-dev mailing list