[foreign] RFR 8221409: jextract generated source fails to compile for Python sources
Henry Jen
henry.jen at oracle.com
Mon Mar 25 16:32:40 UTC 2019
Looks good.
Cheers,
Henry
> On Mar 25, 2019, at 9:34 AM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
>
> Updated: https://cr.openjdk.java.net/~sundar/8221409/webrev.01/
>
> Left out the package name part of the fix - other changes are same.
>
> Thanks,
> -Sundar
>
> On 25/03/19, 9:18 PM, Henry Jen wrote:
>> Pushed 8221336, thanks for the review.
>>
>> Cheers,
>> Henry
>>
>>
>>> On Mar 25, 2019, at 8:32 AM, Sundararajan Athijegannathan<sundararajan.athijegannathan at oracle.com> wrote:
>>>
>>> Missed your RFR somehow! Looks good - but please add copyright dupname.h.
>>>
>>> PS. I'll merge after your push and send fresh RFR.
>>>
>>>
>>> Thanks,
>>> -Sundar
>>>
>>> On 25/03/19, 8:54 PM, Henry Jen wrote:
>>>> Looks good, I have a fix for package name for review earlier (8221336)[1], where I fix the package name issue in HeaderResolver, I believe that makes JavaSourceFactory:88 replace not necessary. If you don’t mind merge the test of that webrev, we can have both in together.
>>>>
>>>> Cheers,
>>>> Henry
>>>>
>>>> [1] https://cr.openjdk.java.net/~henryjen/panama/8221336/webrev/
>>>>
>>>>> On Mar 25, 2019, at 6:37 AM, Sundararajan Athijegannathan<sundararajan.athijegannathan at oracle.com> wrote:
>>>>>
>>>>> Please review.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8221409
>>>>> Webrev: https://cr.openjdk.java.net/~sundar/8221409/webrev.00/
>>>>>
>>>>> Thanks,
>>>>> -Sundar
More information about the panama-dev
mailing list