[foreign] RFR 8221611: prepare jextract tests for generated header, static forwarder name pattern change

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Mar 28 12:02:35 UTC 2019



On 28/03/19, 3:59 PM, Maurizio Cimadamore wrote:
>
> On 28/03/2019 09:57, Sundararajan Athijegannathan wrote:
>> PS. I locally tried name pattern to be foo_h_ and foo_h (for header 
>> interface and static forwarder respectively). Only 11 tests with the 
>> current webrev.
>
> Only 11 tests... what? I guess you mean only 11 tests needs to be 
> touched with this patch?

Yes - with this patch, if name pattern is changed, only 11 tests fail - 
those 11 make static references to generated classes (via import). 
Without this patch, name pattern change will result in lot more 
failuresl -- those with dynamic name computing and call to "loadClass" 
also fail.

Summary: if we make name change, we just need to modify imports in those 
11 tests only.

Thanks
-Sundar
>
> Maurizio
>
>> Tests that use computed name of generated classes/interfaces all pass 
>> before/after name pattern change.


More information about the panama-dev mailing list