[foreign] RFR 8223247: jextract should generate static forwarder regardless of -l option

Jorn Vernee jbvernee at xs4all.nl
Thu May 2 15:23:07 UTC 2019


Regarding the change in Messages.properties;

For the Writer patch I just pushed, there were 3 `cannot.write.xyz.file` 
already. So, I replaced them with a `cannot.write.file` where the `xyz` 
is passed in as a format argument (and this allowed some minor 
simplification of the code in Main as well).

It looks like I missed one use sites of `cannot.write.class.file` in 
JavaSourceFactory. Should this also use `cannot.write.file` and pass in 
"class" as the first formatting argument, or are more specific message 
formats preferred?

Thanks,
Jorn

Sundararajan Athijegannathan schreef op 2019-05-02 16:47:
> Please review.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8223247
> Webrev: https://cr.openjdk.java.net/~sundar/8223247/webrev.00/
> 
> Thanks,
> -Sundar


More information about the panama-dev mailing list