[foreign] RFR 8223289: jextract fails when proprocessor macro and anonymous enum constant have the same name

Fri May 3 10:05:11 UTC 2019

Looks good!

Maurizio

On 03/05/2019 11:04, Sundararajan Athijegannathan wrote:
> Hi,
>
> Thanks. You're right, header interface lifts all enum constants. 
> Updated: https://cr.openjdk.java.net/~sundar/8223289/webrev.01/
>
> Thanks,
> -Sundar
>
> On 03/05/19, 3:18 PM, Maurizio Cimadamore wrote:
>> Hi Sundar,
>> the patch solves the problem I had with unistd.h - thanks!
>>
>> I noted that the code only applies the filtering logic if the enum is 
>> anonymous - but I think the non-static binding always lift enum 
>> constants (anon or not) to the header class, which, I think, means 
>> that all enum constants should be treated as 'global' ?
>>
>> Maurizio
>>
>> On 03/05/2019 10:17, Sundararajan Athijegannathan wrote:
>>> Please review.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8223289
>>> Webrev: https://cr.openjdk.java.net/~sundar/8223289/webrev.00/
>>>
>>> Thanks,
>>> -Sundar