RFR: Improve missing symbols handling

Henry Jen henry.jen at oracle.com
Fri May 3 17:02:16 UTC 2019


Correct.

Cheers,
Henry


> On May 3, 2019, at 10:00 AM, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> Seems like an useful follow up. Just to make sure I understand, if -l is specified, we get same behavior as before. If -l is NOT specified, then the behavior would differ (as we now do the check), and therefore we need the 'ignore' option explicitly, if we want to suppress logging. Right?
> 
> Maurizio
> 
> 
> 
> 
> 
> On 03/05/2019 17:43, Henry Jen wrote:
>> Hi,
>> 
>> Please review a webrev[1] that add the missing —missing-symbols warn support, and turn on symbol checking against default library by default.
>> 
>> This is kind of a follow up to JDK-8223247, as that simply assume we are using the default libraries within JVM if no -l option is provided. This webrev now will
>> 
>> - Same behavior as before if both -l and -L are provided.
>> - Symbol check is turned on always. If there is no -l provided, jextract will check symbols against the default library.
>> - Default is to issue warnings without -l, exclude with explicit -l. This is mostly backward compatible as it doesn’t change generated code/classes, but show warnings to inform user about potential missing libraries.
>> 
>> To be 100% compatible with before, use '—missing-symbols ignore’
>> 
>> Thoughts?
>> 
>> Cheers,
>> Henry
>> 
>> [1] http://cr.openjdk.java.net/~henryjen/panama/missingSymbols/webrev/



More information about the panama-dev mailing list