[foreign-memaccess] RFR 8223629: Remove Descriptor and Function

Jorn Vernee jbvernee at xs4all.nl
Thu May 9 15:02:35 UTC 2019


> This does not apply cleanly for me... I think the flattening of the
> packages was not picked up in the webrev? (I'd expect to see a bunch
> of re-names)

No, sorry, that's the other patch I was missing :)

Jorn

Jorn Vernee schreef op 2019-05-09 16:59:
> This does not apply cleanly for me... I think the flattening of the
> packages was not picked up in the webrev? (I'd expect to see a bunch
> of re-names)
> 
> Otherwise it looks good, but some of the javadoc you copied from
> Descriptor to Layout still mentions "descriptor", where I think it
> should say "layout" instead. e.g.:
> 
> +     * Does this descriptor contain unresolved layouts?
> +     * @return the descriptor name (if any).
> +     * Add annotation to descriptor.
> +     * Attach name annotation to given descriptor.
> +     * @return a new descriptor with desired name annotation.
> +     * Strip all annotations from this (possibly annotated) 
> descriptor.
> +     * @return the unannotated descriptor.
> 
> Jorn
> 
> Maurizio Cimadamore schreef op 2019-05-09 16:36:
>> Hi,
>> this small patch is to remove Descriptor and Function which are unused
>> in the memory access layer. Some simplifications to the Address layout
>> class were needed to adjust for that.
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~mcimadamore/panama/8223629/
>> 
>> Maurizio


More information about the panama-dev mailing list