[foreign] RFR 8224478: TestSrcDump fails on Windows

[Jorn Vernee]

Maybe you're running the test in an elevated shell on the infra?

I was getting something like "a required privilege is not held by the 
client".

I'm on an admin account, but have things set to deny access without 
explicit permission, which AFAIK is the default for most Windows 
distros.

Jorn

Maurizio Cimadamore schreef op 2019-05-21 14:00:
> Question: why was this test passing on our build/test infra?
> 
> ----------System.out:(11/332)----------
> [TestNG] Running:
>   com/sun/tools/jextract/TestSrcDump.java
> 
> test TestSrcDump.testNoPkg(): success
> test TestSrcDump.testTargetDir(): success
> 
> ===============================================
> com/sun/tools/jextract/TestSrcDump.java
> Total tests run: 2, Failures: 0, Skips: 0
> ===============================================
> 
> This is on Win X64, obtained yesterday.
> 
> Maurizio
> 
> On 21/05/2019 11:01, Maurizio Cimadamore wrote:
> 
>> Looks good!
>> 
>> Maurizio
>> 
>> On 21/05/2019 10:59, Jorn Vernee wrote:
>> 
>>> Hi,
>>> 
>>> After recent patch that adds a test that creates a symlink [1].
>>> I'm seeing a few test failures.
>>> 
>>> Creating symlinks is a priviledges action on Windows, so this test
>>> fails with a FileSystemException, and this in turn seems to cause
>>> some other tests to fail as well.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8224478
>>> Webrev:
>>> 
>> 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8224478/webrev.00/
>>> 
>>> 
>>> This moves the symlink test into it's own jtreg test file, which
>>> uses `@requires os.family != "windows"`.
>>> 
>>> Thanks,
>>> Jorn
>>> 
>>> [1] :
>>> 
>> 
> https://mail.openjdk.java.net/pipermail/panama-dev/2019-May/005438.html