[foreign] RFR: 8223808: initial port for AArch64

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue May 28 08:48:01 UTC 2019


Looks very good. Some questions/comments:

* don't you need some extra set of constants under NativeTypes (for 
aarch platform?)

* UnalignedStructTest - why doesn't it work? There's an f128 there but 
we're not actually reading/setting it - it's mostly there to force 
alignment a certain way

* the change to DirectSignatureShuffler is subtle, but I think it's ok 
and shouldn't impact SysV negatively

The rest looks good

Maurizio


On 28/05/2019 08:34, Nick Gasson wrote:
> Hi all,
>
> I've put an updated webrev for the AArch64 port here:
>
> http://cr.openjdk.java.net/~ngasson/foreign/8223808/webrev.2/
>
> This contains all the previous changes plus a few fixes to handle things
> like "heterogeneous float aggregates" (structs/arrays where all the
> members are float/double), which are handled specially in the ABI.
>
> With this patch all the tests in the jdk_foreign group pass on AArch64,
> except the two I disabled pending adding long double support.
>
> Please let me know if you have any feedback!
>
> Thanks,
> Nick


More information about the panama-dev mailing list