[foreign] RFR: 8223808: initial port for AArch64
    Nick Gasson 
    nick.gasson at arm.com
       
    Wed May 29 07:00:30 UTC 2019
    
    
  
Hi Maurizio,
On 28/05/2019 19:25, Maurizio Cimadamore wrote:
> Actually, a cleaner way to get there is:
> 
> public static LayoutType<Short> SHORT = pick(LittleEndian.SysVABI.SHORT, 
> LittleEndian.WinABI.SHORT, LittleEndian.AArch64.SHORT);
> 
> and then define the logic inside pick() to select the right value 
> depending on platform/os.
> 
Yes this is much better. I've done this in webrev.3 here:
http://cr.openjdk.java.net/~ngasson/foreign/8223808/webrev.3/
I added NativeTypes.AArch64ABI which differs from SysVABI in that long 
double is 128 bits and char is unsigned. I wonder if we should add a 
"SCHAR" signed char type to NativeTypes? As currently we have CHAR and 
UCHAR which are both unsigned on AArch64.
Also fixed the x86 regression found by Jorn and re-enabled the 
UnalignedStructTest test.
Thanks,
Nick
    
    
More information about the panama-dev
mailing list