[foreign-memaccess] RFR 8234337: Misc foreign memory acess API cleanups

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Mon Nov 18 19:01:55 UTC 2019


Pushed. I've only changed back one thing: toByteBuffer -> asByteBuffer - 
because 'as' should be used for views, whereas 'to' should be used for 
copy semantics.

Maurizio

On 18/11/2019 15:56, Jorn Vernee wrote:
> Looks good!
>
> Thanks,
> Jorn
>
> On 18/11/2019 16:34, Maurizio Cimadamore wrote:
>> Thanks for the review. New revision:
>>
>> http://cr.openjdk.java.net/~mcimadamore/panama/8234337_v3/
>>
>> http://cr.openjdk.java.net/~mcimadamore/panama/8234337_v3_javadoc
>>
>> Maurizio
>>
>> On 18/11/2019 15:14, Jorn Vernee wrote:
>>> On 18/11/2019 16:09, Maurizio Cimadamore wrote:
>>>> I see that:
>>>>
>>>>  * @apiNote In the future, if the Java language permits, {@link 
>>>> MemoryLayout}
>>>>  * may become a {@code sealed} interface, which would prohibit 
>>>> subclassing except by
>>>>  * explicitly permitted types.
>>>
>>> Oh yes, it was already there :)
>>>
>>> FWIW, I have no further comments on your changes w.r.t. changing 
>>> MemoryHandles::varHandle(Class) to be explicit on byte order.
>>>
>>> Jorn
>>>


More information about the panama-dev mailing list