[vector] Add tests for slice and unslice operations

[Deshpande, Vivek R]

Hi Qi, Yang

Thank you both for the review.
As per Yang's request I am working on separating the patch.
The fix portion of the patch fixes the slice failure.
https://bugs.openjdk.java.net/browse/JDK-8230904
 Will push the fix part first.

Regards,
Vivek

-----Original Message-----
From: Qi Feng (Arm Technology China) [mailto:Qi.Feng at arm.com] 
Sent: Monday, October 14, 2019 12:23 AM
To: Deshpande, Vivek R <vivek.r.deshpande at intel.com>; panama-dev at openjdk.java.net
Subject: RE: [vector] Add tests for slice and unslice operations

Hi Vivek

I've tested your new patch both on x86 and aarch64. Besides slice/unSlice, there aren't new failures.  Please check the following comments:

1. Code indentation.
   - function slice/unslice
   - Unit-Unslice-Masked-bop.template
     static void TEST$vectorteststype$(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb,
     IntFunction<boolean[]> fm) {
   - Unit-Slice-Masked-bop.template
     static void TEST$vectorteststype$(IntFunction<$type$[]> fa, IntFunction<$type$[]> fb,
     IntFunction<boolean[]> fm) {

2. Masks used in newly added assertArraysEquals functions are not printed out.

3. Scalar version for performance comparison is missed.

Thanks,
Qi Feng

-----Original Message-----
From: Deshpande, Vivek R <vivek.r.deshpande at intel.com>
Sent: Thursday, October 10, 2019 2:38 AM
To: Qi Feng (Arm Technology China) <Qi.Feng at arm.com>; panama-dev at openjdk.java.net
Subject: RE: [vector] Add tests for slice and unslice operations

Hi Qi

Thanks for reviewing and taking a look at the patch. I have the updated webrev.
Please find it here which has all the files which were missing in earlier webrev.
http://cr.openjdk.java.net/~vdeshpande/webrev_slice_unslice.01/

I have also fixed some of the problems with the java implementation of slice and unslice.

Regards,
vivek

-----Original Message-----
From: Qi Feng (Arm Technology China) [mailto:Qi.Feng at arm.com]
Sent: Tuesday, October 8, 2019 7:10 PM
To: Deshpande, Vivek R <vivek.r.deshpande at intel.com>; panama-dev at openjdk.java.net
Subject: RE: [vector] Add tests for slice and unslice operations

Hi Vivek,

I have verified this patch locally, and there're some issues with it.

After I applied this patch and ran the gen-tests.sh script again, the generated java test files are changed. They should keep the same as before. Did you modify the generated java test files manually?  Before this patch, the java test files are generated by gen-test.sh totally.

In addition, I also want to know how you add scalar functions like

  static byte[] slice(byte[] a, int origin, int idx) {

to the java files. I couldn't find the definitions in any template files you modified.

Regards,
Qi Feng

-----Original Message-----
From: panama-dev <panama-dev-bounces at openjdk.java.net> On Behalf Of Deshpande, Vivek R
Sent: Tuesday, October 1, 2019 8:51 AM
To: panama-dev at openjdk.java.net
Subject: [vector] Add tests for slice and unslice operations

Hi All

Could you please review the patch for tests for slice and unsliced.
http://cr.openjdk.java.net/~vdeshpande/webrev_slice_unslice/
Code contributed by: Vikash Kumar (vikash1.kumar at intel.com<mailto:vikash1.kumar at intel.com>)
And Vivek Deshpande(vdeshpande)

Regards,
Vivek
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.