[foreign-abi] RFR 8230806: Use libTestUpcall in TestUpcall

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Sep 10 12:44:11 UTC 2019


Looks good, thanks for catching (and fixing) this.

Maurizio

On 10/09/2019 13:07, Jorn Vernee wrote:
> Hi,
>
> While working on another patch I noticed the current TestUpcall test 
> is loading the downcall test library instead of the upcall test 
> library. This means that the upcall tests were not actually using the 
> callback that they were being passed. I've changed the library that is 
> loaded, and added some checks that check that the callback is actually 
> being called. (this also revealed a small bug in 
> UniversalUpcallHandler that I fixed)
>
> Please review the following:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8230806
> Webrev: 
> http://cr.openjdk.java.net/~jvernee/panama/webrevs/8230806/webrev.00/
>
> Thanks,
> Jorn
>


More information about the panama-dev mailing list