[foreign-abi] RFR: Revert "JDK-8242127: reorganize ABI-dependent layout constants"

[Athijegannathan Sundararajan]

On Mon, 6 Apr 2020 15:06:14 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This reverts commit f7e7b9d6e76e54b1b5d4ff97d2a034769652e132.
> 
> The latest reorganization of SystemABI constants did not work with the jextract code, for two reasons:
> 
> 1) jextract internally converts C types into layouts, and then expects to emit source files which have the 'right'
> constants (e.g. C_INT, if the layout is that of a C int)
> 2) for tests, for making sure that the layout of a given e.g. struct field matches the expected one
> 
> Of course (1) could be avoided by just re-creating the constant from scratch, but that would lead to footprint issues,
> and would still not address (2).
> So, I'm postponing for now - we'll reserve to make changes in this area in the future.

Looks good!

-------------

Marked as reviewed by sundar (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/99