[foreign-jextract] RFR: Tweak JextractToolRunner to use file helper routines in FileUtils library

Henry Jen henryjen at openjdk.java.net
Mon Apr 6 21:56:16 UTC 2020


On Mon, 6 Apr 2020 20:37:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> This is an attempt to fix some of the jextract tests that are failing in our build infra; I looked over the tests and I
> couldn't find anything obviously wrong (such as streams left open and such). But speaking with Alan, he raised the
> possibility that the failures are a result of a known bad interaction with the AV solution installed in some of the
> Windows test machines. To workaround this, we have an helper library called FileUtils which has a deleteFileWithRetry
> method, which is meant to address these issues. I think it could be worth trying whether this fixes our issues before
> investigating further - in any case, at the very least this patch improves the code by reusing sharing helper
> functionalities already available in the test folder.

Looks good to me.

-------------

Marked as reviewed by henryjen (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/100


More information about the panama-dev mailing list