[foreign-jextract] [Rev 01] RFR: 8239493: Add classfile generation to jextract

Jorn Vernee jvernee at openjdk.java.net
Tue Apr 7 13:01:11 UTC 2020


On Tue, 7 Apr 2020 10:53:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix incorrect copyright header
>
> src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/tool/resources/RuntimeHelper.java.template line 56:
> 
>> 55:
>> 56:     public static final MemoryAddress makeCString(String value) {
>> 57:         value += '\0';
> 
> Why this? Don't we have the new Cstring type?

After offline discussion, I've removed this and am now calling Cstring::toCString

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/102


More information about the panama-dev mailing list