[vector] Remove unnecessary node AbsV

Qi Feng Qi.Feng at arm.com
Tue Apr 14 06:01:33 UTC 2020


Thanks Vladimir. I'll keep that in mind.

Best regards,
Qi

-----Original Message-----
From: Vladimir Ivanov <vladimir.x.ivanov at oracle.com> 
Sent: Monday, April 13, 2020 4:36 PM
To: Qi Feng <Qi.Feng at arm.com>; panama-dev at openjdk.java.net
Cc: nd <nd at arm.com>
Subject: Re: [vector] Remove unnecessary node AbsV

Hi Qi,

> We already have nodes AbsVB/AbsVI/AbsVD/AbsVF/AbsVS/AbsVL for every 
> primitive type. These nodes can cover all situations. So AbsV can be removed.
> 
> Please help me review this patch.
> 
> Webrev: 
> http://cr.openjdk.java.net/~qfeng/panama/vectorapi/remove_absv/webrev/

Looks good.

In the longer term, I prefer us to move in the opposite direction: 
replace the family of type-specific nodes per operation with a single generic node and during matching rely on vector type info
(n->bottom_type()->is_vect()) to choose proper implementation.

Best regards,
Vladimir Ivanov


More information about the panama-dev mailing list