[vector] RFR(T/S) 8242889: test/jdk/jdk/incubator/vector/VectorConversionTests.java fails by timeout

Paul Sandoz paul.sandoz at oracle.com
Wed Apr 22 16:44:00 UTC 2020


Looks good, thanks,
Paul.

> On Apr 22, 2020, at 9:38 AM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
> 
> Paul,
> 
> I moved all common stuff into AbstractVectorConversionTest.java.
> Please find new webrev here:
> http://cr.openjdk.java.net/~epavlova//8242889/webrev.01/index.html
> 
> testing: tested by running all new tests
> 
> 
> Regards,
> -katya
> 
> 
> On 4/21/20 4:57 PM, Ekaterina Pavlova wrote:
>> Ok, let me move the common code into a base class.
>> regards,
>> -katya
>> On 4/21/20 4:54 PM, Paul Sandoz wrote:
>>> Hi,
>>> 
>>> Thanks for doing this.  If you are gonna separate you could you place common code in a base class?
>>> 
>>> I believe everything but vector species constants and the @Test annotated methods could be shared.
>>> 
>>> Thanks.
>>> Paul.
>>> 
>>>> On Apr 21, 2020, at 4:46 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>>> 
>>>> Hello,
>>>> 
>>>> test/jdk/jdk/incubator/vector/VectorConversionTests.java is very large test
>>>> and in most cases it fails by timeout with default jtreg settings. It could
>>>> take more than 10 mins which is more than default jtreg timeout. This test
>>>> is not auto-generated from templates so I just split the test into 5 smaller
>>>> ones (each consisting of 576 test cases):
>>>> 
>>>> Vector64ConversionTests.java
>>>> Vector128ConversionTests.java
>>>> Vector256ConversionTests.java
>>>> Vector512ConversionTests.java
>>>> VectorMaxConversionTests.java
>>>> 
>>>> 
>>>> Please review the changes:
>>>> 
>>>>       JBS: https://bugs.openjdk.java.net/browse/JDK-8242889
>>>>    webrev: http://cr.openjdk.java.net/~epavlova//8242889/webrev.00/index.html
>>>>   testing: tested by running new tests
>>>> 
>>>> 
>>>> thanks,
>>>> -katya
>>> 
> 



More information about the panama-dev mailing list