[foreign-jextract] RFR: 8243978: jextract should generate separate classes with static util methods for each struct, union

[Jorn Vernee]

On Tue, 28 Apr 2020 09:52:47 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> JavaSourceBuilder refactored. HeaderBuilder, StructBuilder are added.

Looks good! One minor comment.

src/jdk.incubator.jextract/share/classes/jdk/incubator/jextract/tool/HeaderBuilder.java line 46:

> 45:         this.sb.delete(0, res.length());
> 46:         List<JavaFileObject> outputs = new ArrayList<>(constantHelper.getClasses());
> 47:         outputs.add(Utils.fileFromString(pkgName, className, res));

Now that the same ConstantHelper instance is shared by mutliple generators, I think it makes sense to move the
`ConstantHelper::getClasses()` call to `OutputFactory::generate`, to show that its output is not just an implementation
detail of `HeaderBuilder`.

-------------

Marked as reviewed by jvernee (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/133