[foreign-jextract] [Rev 01] RFR: 8244172: jextract should generate upcall stub creating helper in the functional interface class

Maurizio Cimadamore mcimadamore at openjdk.java.net
Thu Apr 30 12:18:15 UTC 2020


On Thu, 30 Apr 2020 12:09:14 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

>> * moved the upcall stub creating utility method as static method of functional interface
>> * added free upcall stub utility to RuntimeHelper
>> * added a simple test for function pointer callback
>
> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last
> revision:
>   renamed upcall stub factory method "$make" as "allocate"

Looks good - as discussed online we might want at some point to revisit the callback machinery so that:

1) we can create a callback segment which is not confined, and whose close() does the right thing
2) we allow for attaching callback segment onto an existing NativeAllocationScope

-------------

Marked as reviewed by mcimadamore (Committer).

PR: https://git.openjdk.java.net/panama-foreign/pull/138


More information about the panama-dev mailing list