[foreign-jextract] RFR: 8251893: jextract does not generate source for ConstantHelper even when --source is used

[Maurizio Cimadamore]

On Mon, 17 Aug 2020 13:36:40 GMT, Athijegannathan Sundararajan <sundar at openjdk.org> wrote:

> ConstantHelper.java is generated when --source is used

Looks very good.
We should probably try all examples and see that they work even against --source mode, to make sure we haven't missed
anything.

src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/SourceConstantHelper.java line 46:

> 45: // generates ConstantHelper as java source
> 46: class SourceConstantHelper implements ConstantHelper {
> 47:     private static final String PRIVATE_MODS = "private static final ";

Shouldn't this extend JavaSourceBuilder, which has all the interesting source generation methods?

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/283