[foreign-jextract] RFR: 8252016: jextract should handle va_list [v2]

[Maurizio Cimadamore]

On Wed, 19 Aug 2020 11:11:19 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last
>> revision:
>>   Removed unused import. Removed unwanted comment character.
>
> src/jdk.incubator.jextract/share/classes/jdk/internal/jextract/impl/resources/RuntimeHelper.java.template line 88:
> 
>> 87:                     return variadic || isVaList(fdesc)?
>> 88:                         VarargsInvoker.make(addr, mt, fdesc) :
>> 89:                         ABI.downcallHandle(addr, mt, fdesc);
> 
> I don't get this change - we don't want a vararg invoker for a valist call, right? The invoker will most surely not do
> the right thing here.
> Also, the test seems to show that no Java varargs invocation is being applied (which is correct), so what is the
> reasons for the changes in RuntimeHelper?

missng space between `variadic` and `?`

-------------

PR: https://git.openjdk.java.net/panama-foreign/pull/285